Bug 6664

Summary:

Inspector does not highlight SVG elements properly

Product:

WebKit

Reporter:

Michael Croft <mcroft>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

URL:

http://webkit.opendarwin.org/blog/wp-content/rotate.svg

Attachments:

Description	Flags
Inspector/SVG interaction	none
Proposed fix for highlighting problems	darin: review+
Fix for image absolute rect calcs	none
Combined patch	eric: review+

Michael Croft

Reported 2006-01-18 19:39:01 PST

Inspector does not highlight SVG elements properly. Cannot select SVG element in browser. If SVG element selected in Inspector, wrong region highlighted. See Picture.

Attachments
Inspector/SVG interaction (112.07 KB, image/png) 2006-01-18 19:39 PST, Michael Croft	no flags	Details
Proposed fix for highlighting problems (5.37 KB, patch) 2006-04-08 12:21 PDT, Rob Buis	darin: review+	Details Formatted Diff Diff
Fix for image absolute rect calcs (1.95 KB, patch) 2006-04-09 12:50 PDT, Rob Buis	no flags	Details Formatted Diff Diff
Combined patch (5.56 KB, patch) 2006-04-18 13:38 PDT, Rob Buis	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Croft

Comment 1 2006-01-18 19:39:56 PST

Created attachment 5773 [details] Inspector/SVG interaction

Joost de Valk (AlthA)

Comment 2 2006-02-17 01:15:19 PST

Confirmed, lowering priority to 3, since this won't kill anyone ;)

Rob Buis

Comment 3 2006-04-08 12:21:27 PDT

Created attachment 7583 [details] Proposed fix for highlighting problems

Eric Seidel (no email)

Comment 4 2006-04-08 15:50:02 PDT

Comment on attachment 7583 [details] Proposed fix for highlighting problems Can't all of these just be implemented like this: +void RenderPath::absoluteRects(DeprecatedValueList<IntRect>& rects, int _tx, int _ty) +{ + rects.append(getAbsoluteRepaintRect()); +} maybe that should be the default RenderObject implementation...

Darin Adler

Comment 5 2006-04-08 20:05:16 PDT

Comment on attachment 7583 [details] Proposed fix for highlighting problems Looks fine. r=me

Rob Buis

Comment 6 2006-04-09 12:50:04 PDT

Created attachment 7604 [details] Fix for image absolute rect calcs Eric, Indeed, using getAbsoluteRepaintRect everywhere would be nicer. I think text may be a special case and I am not sure whether we should try to use that approach there yet. However for images I think it is possible as the patch shows. The layout tests are still fine after that. However I am not sure in what cases the getAbsoluteRepaintRect for svg images get called, so I am not 100% certain it will work... Cheers, Rob.

Timothy Hatcher

Comment 7 2006-04-15 12:34:28 PDT

Does this new patch need another review?

Darin Adler

Comment 8 2006-04-16 23:48:49 PDT

I'd like to land the patch, but I can't tell what state the bug is in. Should I land one patch, or both? If one of the patches I'm supposed to land is the newer one, who reviewed the new patch and where is the change log?

Rob Buis

Comment 9 2006-04-18 13:38:07 PDT

Created attachment 7809 [details] Combined patch

Eric Seidel (no email)

Comment 10 2006-04-18 13:44:10 PDT

Comment on attachment 7809 [details] Combined patch This looks great, let's land. :) Whoever lands will have to update the layout test results as well. (Ideally the patch should include those, but in this case we can update them manually.)

Eric Seidel (no email)

Comment 11 2006-04-19 04:00:26 PDT

This doesn't fix all of the inspector issues for SVG, but is certianly an improvement!

Note You need to log in before you can comment on or make changes to this bug.