Bug 66638 – Range::setEnd(const Position&, ExceptionCode) calls setStart() instead of setEnd()

• Component: HTML Editing
• Status: RESOLVED FIXED

[Alice Boxhall]

Range::setEnd, introduced in bug 64403, incorrectly calls setStart(PassRefPtr<Node> refNode, int offset, ExceptionCode& ec) instead of the equivalent setEnd() method.

[Alice Boxhall]

Created attachment 104640 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 104640 [details]
Patch

Oops, that was careless.  Thanks for fixing it.

[Ryosuke Niwa]

Comment on attachment 104640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104640&action=review

> Source/WebCore/ChangeLog:8
> +        Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)

The patch for this bug doesn't appear to use setEnd.  Maybe a wrong bug number?

[Alice Boxhall]

(In reply to comment #3)
> (From update of attachment 104640 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=104640&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)
> 
> The patch for this bug doesn't appear to use setEnd.  Maybe a wrong bug number?

The patch doesn't, but the surrounding code does, in AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition&). The test for this patch exercises this code (which is how I found this bug in the first place).

[Alice Boxhall]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 104640 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=104640&action=review
> > 
> > > Source/WebCore/ChangeLog:8
> > > +        Relevant layout test coming in a future patch (see https://bugs.webkit.org/show_bug.cgi?id=65900)
> > 
> > The patch for this bug doesn't appear to use setEnd.  Maybe a wrong bug number?
> 
> The patch doesn't, but the surrounding code does, in AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition&). The test for this patch exercises this code (which is how I found this bug in the first place).

Oh, and that patch is out of date; I was waiting for this fix before I updated it, but now I realise that's unnecessary, so I'll update it now.

[WebKit Review Bot]

Comment on attachment 104640 [details]
Patch

Clearing flags on attachment: 104640

Committed r93574: <http://trac.webkit.org/changeset/93574>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.