| Summary: | [Qt] QWebSpellChecker plugins crash webkit | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lindsay Mathieson <lindsay.mathieson> | ||||||||
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Major | CC: | adawit, benjamin, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Lindsay Mathieson
2011-08-20 20:13:56 PDT
(In reply to comment #0) > TextCheckerClientQt.cpp loads the plugin via a locla instance of QtPlatformPlugin - when this is destroyed it unloads the plugin, leaving a QWebSpellChecker pointer to invalid memory. I think you forget to post the patch... Created attachment 104624 [details]
Patch
(In reply to comment #1) > (In reply to comment #0) > > TextCheckerClientQt.cpp loads the plugin via a locla instance of QtPlatformPlugin - when this is destroyed it unloads the plugin, leaving a QWebSpellChecker pointer to invalid memory. > > I think you forget to post the patch... Done - still battling with the upload scripts :) Created attachment 104627 [details]
Patch
Comment on attachment 104627 [details]
Patch
The patch seems to be the correct fix but the Changelog is not correctly formatted.
It should be:
-title
-url
-reviewer line
-description
-changelist with more description if necessary.
----
The description could also be better. Something briefly explaining the bug e.g.:
"The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the plugin at the end of the scope.
This patch moves the local creation of QtPlatformPlugin to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading of plugin."
Created attachment 104628 [details]
Patch
(In reply to comment #6) (In reply to comment #5) > (From update of attachment 104627 [details]) > The patch seems to be the correct fix but the Changelog is not correctly formatted. Done, thanks, Comment on attachment 104628 [details]
Patch
Great, let's land it.
Comment on attachment 104628 [details] Patch Clearing flags on attachment: 104628 Committed r93490: <http://trac.webkit.org/changeset/93490> All reviewed patches have been landed. Closing bug. |