Bug 66628

Summary:

[Qt] QWebSpellChecker plugins crash webkit

Product:

WebKit

Reporter:

Lindsay Mathieson <lindsay.mathieson>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

adawit, benjamin, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Lindsay Mathieson

Reported 2011-08-20 20:13:56 PDT

TextCheckerClientQt.cpp loads the plugin via a locla instance of QtPlatformPlugin - when this is destroyed it unloads the plugin, leaving a QWebSpellChecker pointer to invalid memory.

Attachments
Patch (2.08 KB, patch) 2011-08-20 20:41 PDT, Lindsay Mathieson	no flags	Details Formatted Diff Diff
Patch (2.25 KB, patch) 2011-08-21 04:58 PDT, Lindsay Mathieson	no flags	Details Formatted Diff Diff
Patch (2.39 KB, patch) 2011-08-21 06:33 PDT, Lindsay Mathieson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dawit A.

Comment 1 2011-08-20 20:25:11 PDT

(In reply to comment #0) > TextCheckerClientQt.cpp loads the plugin via a locla instance of QtPlatformPlugin - when this is destroyed it unloads the plugin, leaving a QWebSpellChecker pointer to invalid memory. I think you forget to post the patch...

Lindsay Mathieson

Comment 2 2011-08-20 20:41:37 PDT

Created attachment 104624 [details] Patch

Lindsay Mathieson

Comment 3 2011-08-20 20:42:38 PDT

(In reply to comment #1) > (In reply to comment #0) > > TextCheckerClientQt.cpp loads the plugin via a locla instance of QtPlatformPlugin - when this is destroyed it unloads the plugin, leaving a QWebSpellChecker pointer to invalid memory. > > I think you forget to post the patch... Done - still battling with the upload scripts :)

Lindsay Mathieson

Comment 4 2011-08-21 04:58:08 PDT

Created attachment 104627 [details] Patch

Benjamin Poulain

Comment 5 2011-08-21 06:21:44 PDT

Comment on attachment 104627 [details] Patch The patch seems to be the correct fix but the Changelog is not correctly formatted. It should be: -title -url -reviewer line -description -changelist with more description if necessary. ---- The description could also be better. Something briefly explaining the bug e.g.: "The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading of plugin."

Lindsay Mathieson

Comment 6 2011-08-21 06:33:28 PDT

Created attachment 104628 [details] Patch

Lindsay Mathieson

Comment 7 2011-08-21 06:34:32 PDT

(In reply to comment #6) (In reply to comment #5) > (From update of attachment 104627 [details]) > The patch seems to be the correct fix but the Changelog is not correctly formatted. Done, thanks,

Benjamin Poulain

Comment 8 2011-08-21 07:41:15 PDT

Comment on attachment 104628 [details] Patch Great, let's land it.

WebKit Review Bot

Comment 9 2011-08-21 08:54:07 PDT

Comment on attachment 104628 [details] Patch Clearing flags on attachment: 104628 Committed r93490: <http://trac.webkit.org/changeset/93490>

WebKit Review Bot

Comment 10 2011-08-21 08:54:11 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.