Summary: | Would like to be able to reuse DynamicDeviceScaleFactor's code in other WebKit-agnostic tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ddkilzer, dslomov, levin, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-08-19 07:35:07 PDT
Created attachment 104509 [details]
Patch
Comment on attachment 104509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104509&action=review > Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:33 > +class WebKitAgnosticTest : public ::testing::Test { Please put a comment here explaining what a WebKitAgnosticTest is, I had a hard time understanding until i saw runWebKit1Test and runWebKit2Test. > Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:53 > +void WebKitAgnosticTest::loadSynchronously(View view, NSURL *url) Not sure if this is the best name - it's not really doing a synchronous load. Maybe loadAndWaitUntilFinished? Comment on attachment 104509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104509&action=review >> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:33 >> +class WebKitAgnosticTest : public ::testing::Test { > > Please put a comment here explaining what a WebKitAgnosticTest is, I had a hard time understanding until i saw runWebKit1Test and runWebKit2Test. Added this comment: This test fixture can be used to write tests that work with both WebKit1 and WebKit2. >> Tools/TestWebKitAPI/mac/WebKitAgnosticTest.h:53 >> +void WebKitAgnosticTest::loadSynchronously(View view, NSURL *url) > > Not sure if this is the best name - it's not really doing a synchronous load. Maybe loadAndWaitUntilFinished? Renamed. Committed r93405: <http://trac.webkit.org/changeset/93405> |