Bug 66550 – [CSS Regions] Test absolute positioning of an element inside a CSS region

• Component: CSS
• Status: RESOLVED FIXED

[Razvan Caliman]

Test that, according to the CSS Regions Module, absolutely positioned elements from a flow respect the initial containing block defined by the first region in the region chain.

[Razvan Caliman]

Created attachment 104496 [details]
Patch

[Tony Chang]

Comment on attachment 104496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104496&action=review

> LayoutTests/fast/regions/hit-test-absolute-position.html:42
> +        var hitElement = document.elementFromPoint(270, 330);

The coordinates of the box seems unreliable because of the text at the top of the page.  E.g., other platforms may have different font size or spacing causing the box to be positioned higher or lower.

I would either compute the location of the 'region' div via javascript (you will find many existing tests that use eventSender.mouse* functions that do this) or put the text below the region div.

[Razvan Caliman]

Created attachment 104680 [details]
Patch

Thank you, Tony!
I have updated the test to place the tested elements before the descriptive text. I also added a css reset for margins for good measure.

Mihnea, if you could also have a look, I appreciate it.

[Tony Chang]

Comment on attachment 104680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104680&action=review

> LayoutTests/platform/mac-snowleopard/fast/regions/hit-test-absolute-position-expected.txt:2
> +PASS
> +Test that absolutely positioned elements inside a flow respect the initial containing block defined by the first region.

You don't need this file since it's the same as LayoutTests/fast/regions/hit-test-absolute-position-expected.txt.

[Razvan Caliman]

Created attachment 104849 [details]
Patch

I have reworked the patch and removed the platform-specific test files.

[WebKit Review Bot]

Attachment 104849 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Razvan Caliman]

Created attachment 104852 [details]
Patch

Fixed the patch by removing the platform-specific baseline. With correct ChangeLog entry this time.

[Tony Chang]

Comment on attachment 104852 [details]
Patch

Sorry for the slow review.

[WebKit Review Bot]

Comment on attachment 104852 [details]
Patch

Rejecting attachment 104852 [details] from commit-queue.

New failing tests:
fast/regions/hit-test-absolute-position.html
Full output: http://queues.webkit.org/results/11569121

[Tony Chang]

(In reply to comment #9)
> (From update of attachment 104852 [details])
> Rejecting attachment 104852 [details] from commit-queue.
> 
> New failing tests:
> fast/regions/hit-test-absolute-position.html
> Full output: http://queues.webkit.org/results/11569121

Oh, this might be because of the recent work to make regions runtime switchable?

[Mihai Balan]

There are already some tests for this, like those for the bug 88133 and others.

Closing as Resolved/Fixed.