Summary: | [webkit-gtk] Run-time error while trying to run GtkLauncher with no video support. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nayan Kumar K <nayankk> | ||||||
Component: | WebKitGTK | Assignee: | Nayan Kumar K <nayankk> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | mrobinson, pnormand, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Nayan Kumar K
2011-08-18 23:18:58 PDT
Created attachment 104469 [details]
Run time error fix
Attachment 104469 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:4: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5]
Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 104469 [details]
Run time error fix
The Fullscreen feature doesn't depend on VIDEO, ideally it's RenderThemeGtk.cpp that needs to be fixed. For the ChangeLog you can use the prepare-ChangeLog script :)
(In reply to comment #3) > (From update of attachment 104469 [details]) > The Fullscreen feature doesn't depend on VIDEO, ideally it's RenderThemeGtk.cpp that needs to be fixed. On the first look, that was my guess too. However, when I looked at how this is being implemented in other ports, (Source/WebCore/rendering/RenderThemeChromiumMac.h, Source/WebCore/rendering/RenderThemeMac.h and Source/WebCore/rendering/RenderThemeWin.h), they seems to be implementing it the other way! Given this, which way should we follow? (Does full screen here implies full screen video?) For the ChangeLog you can use the prepare-ChangeLog script :) My emacs being the culprit here!. Will correct the patch and upload the new patch shortly! Created attachment 104473 [details]
Updated patch, corrected indentation
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 104469 [details] [details]) > > The Fullscreen feature doesn't depend on VIDEO, ideally it's RenderThemeGtk.cpp that needs to be fixed. > > On the first look, that was my guess too. However, when I looked at how this is being implemented in other ports, (Source/WebCore/rendering/RenderThemeChromiumMac.h, Source/WebCore/rendering/RenderThemeMac.h and Source/WebCore/rendering/RenderThemeWin.h), they seems to be implementing it the other way! Given this, which way should we follow? (Does full screen here implies full screen video?) > Right let's do it like this then :) Comment on attachment 104473 [details] Updated patch, corrected indentation Clearing flags on attachment: 104473 Committed r93391: <http://trac.webkit.org/changeset/93391> All reviewed patches have been landed. Closing bug. |