Bug 66522

Summary: Test how HTMLAnchorElement.getParameter reacts to too few arguments
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mjs, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 66235    
Attachments:
Description Flags
Patch
none
Patch none

Description Mark Pilgrim (Google) 2011-08-18 19:48:23 PDT
Test how HTMLAnchorElement.getParameter reacts to too few arguments
Comment 1 Mark Pilgrim (Google) 2011-08-18 19:52:31 PDT
Created attachment 104440 [details]
Patch
Comment 2 Darin Adler 2011-08-18 21:21:39 PDT
Comment on attachment 104440 [details]
Patch

Looks fine. Two comments:

    1) It's probably better to have each test cover more than one function. A separate test for each function will bulk up the test directory and has few benefits.

    2) Using a separate script-tests source file is a bit of an anti-pattern. Alexey Proskuryakov has pointed out that you get almost all the same benefits if you put the script directly into the HTML file. You can still use the js-test files.
Comment 3 Mark Pilgrim (Google) 2011-09-08 14:22:33 PDT
Created attachment 106788 [details]
Patch
Comment 4 Mark Pilgrim (Google) 2011-09-08 14:23:30 PDT
Merged separate script-tests file into HTML file
Comment 5 Adam Barth 2011-09-08 14:27:21 PDT
I agree that it makes sense to merge related tests.  For example, I think the plan is to put all the validity-state tests together.  We'll see how these shake out.
Comment 6 WebKit Review Bot 2011-09-08 19:56:44 PDT
Comment on attachment 106788 [details]
Patch

Clearing flags on attachment: 106788

Committed r94829: <http://trac.webkit.org/changeset/94829>
Comment 7 WebKit Review Bot 2011-09-08 19:56:49 PDT
All reviewed patches have been landed.  Closing bug.