Summary: | Switch RenderBlock to to new layout types | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | eric, leviw, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 63567 | ||||||||
Attachments: |
|
Description
Emil A Eklund
2011-08-18 14:57:26 PDT
Created attachment 104403 [details]
Patch
Comment on attachment 104403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104403&action=review > Source/WebCore/rendering/RenderBlock.cpp:1349 > + repaintRect.intersect(LayoutRect(0, 0, width(), height())); I'm surprised there isn't a size() function to use here. > Source/WebCore/rendering/RenderBlock.h:823 > + typedef PODInterval<int, FloatingObject*> FloatingObjectInterval; > + typedef PODIntervalTree<int, FloatingObject*> FloatingObjectTree; ? (In reply to comment #2) > (From update of attachment 104403 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104403&action=review > > > Source/WebCore/rendering/RenderBlock.cpp:1349 > > + repaintRect.intersect(LayoutRect(0, 0, width(), height())); > > I'm surprised there isn't a size() function to use here. There is, rewrote it as LayoutRect(LayoutPoint(), size()) > > > Source/WebCore/rendering/RenderBlock.h:823 > > + typedef PODInterval<int, FloatingObject*> FloatingObjectInterval; > > + typedef PODIntervalTree<int, FloatingObject*> FloatingObjectTree; Argh, merge failure, reverted. Thanks. Created attachment 104535 [details]
Patch for landing
Comment on attachment 104535 [details] Patch for landing Clearing flags on attachment: 104535 Committed r93436: <http://trac.webkit.org/changeset/93436> All reviewed patches have been landed. Closing bug. |