Bug 66468 – REGRESSION(r93294): Mac 10.6 test failures (Requested by vitalyr on #webkit).

• Component: New Bugs
• Status: RESOLVED FIXED

[WebKit Review Bot]

http://trac.webkit.org/changeset/93294 broke the build:
Mac 10.6 test failures (Requested by vitalyr on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 104342 [details]
ROLLOUT of r93294

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.

[Nico Weber]

Log: http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/6319

Failing tests:

BrowserWindowFullScreenControllerTest.TestActivate: 
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm:703: Failure
Value of: IsFrontWindow([controller_ createFullscreenWindow])
  Actual: false
Expected: true


GrabWindowSnapshotTest.TestGrabWindowSnapshot: 
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm:41: Failure
Value of: CGImageGetWidth([rep CGImage]) == 400
  Actual: false
Expected: true
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm:45: Failure
Expected: (red + green + blue) >= (3.0), actual: 0 vs 3


BrowserCrApplicationAppleScriptTest.InsertWindow: 
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/applescript/browsercrapplication+applescript_test.mm:57: Failure
Value of: [window uniqueID]
  Actual: 1
Expected: var
Which is: 4


RenderViewTest.MacTestCmdUp: 
/b/build/slave/Mac10_6_Tests/build/src/chrome/../content/renderer/render_view_browsertest_mac.mm:103: Failure
Value of: UTF16ToASCII(output)
  Actual: "40,false,false,true,false\np1\n\np2"
Expected: kArrowDownScrollDown
Which is: "40,false,false,true,false
1936
p1

p2"
/b/build/slave/Mac10_6_Tests/build/src/chrome/../content/renderer/render_view_browsertest_mac.mm:112: Failure
Value of: UTF16ToASCII(output)
  Actual: "38,false,false,true,false\np1\n\np2"
Expected: kArrowUpScrollUp
Which is: "38,false,false,true,false
0
p1

p2"


WindowAppleScriptTest.WindowOrder: 
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/applescript/window_applescript_test.mm:175: Failure
Value of: NSOrderedAscending
  Actual: -1
Expected: [window1.get() windowComparator:window2.get()]
Which is: 1
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/ui/cocoa/applescript/window_applescript_test.mm:177: Failure
Value of: NSOrderedDescending
  Actual: 1
Expected: [window2.get() windowComparator:window1.get()]
Which is: -1


PPAPITest.Scrollbar: 
Thu Aug 18 06:15:12 mini9-m1.golo.chromium.org Chromium[14210] <Error>: kCGErrorIllegalArgument: CGSOrderWindowList
Thu Aug 18 06:15:12 mini9-m1.golo.chromium.org Chromium[14210] <Error>: kCGErrorFailure: Set a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged.
/b/build/slave/Mac10_6_Tests/build/src/chrome/test/ui/ppapi_uitest.cc:112: Failure
Value of: escaped_value.c_str()
  Actual: "HandleEvent FAIL: Didn't get callback for scrollbar value change"
Expected: "PASS"

AccessibilityMacUITest.TestInitialPageNotifications: 
Thu Aug 18 06:20:07 mini9-m1.golo.chromium.org Chromium[14821] <Error>: kCGErrorIllegalArgument: CGSOrderWindowList
Thu Aug 18 06:20:07 mini9-m1.golo.chromium.org Chromium[14821] <Error>: kCGErrorFailure: Set a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged.
Killed (timed out).


BrowserFocusTest.ClickingMovesFocus: 
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/browser_focus_uitest.cc:209: Failure
Value of: IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)
  Actual: false
Expected: true


BrowserFocusTest.FindFocusTest: 
/b/build/third_party/zope/__init__.py:19: UserWarning: Module twisted was already imported from /b/build/third_party/twisted_8_1/twisted/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
  import pkg_resources
/b/build/third_party/zope/__init__.py:19: UserWarning: Module zope was already imported from /b/build/third_party/zope/__init__.pyc, but /System/Library/Frameworks/Python.framework/Versions/2.6/Extras/lib/python is being added to sys.path
  import pkg_resources
/b/build/slave/Mac10_6_Tests/build/src/chrome/browser/browser_focus_uitest.cc:778: Failure
Value of: IsViewFocused(VIEW_ID_FIND_IN_PAGE_TEXT_FIELD)
  Actual: false
Expected: true




RenderViewTest.MacTestCmdUp just needs to be rebased. PPAPITest.Scrollbar and AccessibilityMacUITest.TestInitialPageNotifications might also be caused by my change. I'm surprised by the other failures.

[WebKit Review Bot]

Comment on attachment 104342 [details]
ROLLOUT of r93294

Rejecting attachment 104342 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
WebKit/chromium/features.gypi
Hunk #1 FAILED at 154.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/features.gypi.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1
Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9424638

[Tony Chang]

Rolled out in http://trac.webkit.org/changeset/93313

[Nico Weber]

I tried reproducing the failures locally and got:

unit_tests:
[       OK ] BrowserWindowFullScreenControllerTest.TestActivate (697 ms)
[       OK ] GrabWindowSnapshotTest.TestGrabWindowSnapshot (44 ms)

browser_tests:
[       OK ] BrowserCrApplicationAppleScriptTest.InsertWindow (1495 ms)
[  FAILED  ] RenderViewTest.MacTestCmdUp (1574 ms)
[       OK ] WindowAppleScriptTest.WindowOrder (1440 ms)

ui_tests:
[  FAILED  ] PPAPITest.Scrollbar (3870 ms)

interactive_ui_tests:
[ RUN      ] AccessibilityMacUITest.TestInitialPageNotifications
[0820/193458:ERROR:out_of_proc_test_runner.cc(388)] Test timeout (45000 ms) exceeded for AccessibilityMacUITest.TestInitialPageNotifications
[       OK ] BrowserFocusTest.ClickingMovesFocus (1938 ms)
[       OK ] BrowserFocusTest.FindFocusTest (5886 ms)


Only RenderViewTest.MacTestCmdUp, PPAPITest.Scrollbar, and AccessibilityMacUITest.TestInitialPageNotifications seem to be caused by my patch, the rest was some form of flakiness.

[Nico Weber]

AccessibilityMacUITest.TestInitialPageNotifications fails without this change for me locally as well. http://codereview.chromium.org/7694021/ Fixes that both with and without the smooth scrolling change.

[Nico Weber]

http://codereview.chromium.org/7693019/ fixes the problems with the two remaining bugs