Bug 66413 – WebCore requires every WebKit port to keep track of the device scale factor

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Adam Roben (:aroben)]

WebCore currently requires every WebKit port to keep track of the device scale factor, and to only call down into WebCore when the device scale factor has actually changed. It would be much easier if WebCore kept track of the device scale factor itself so that WebKit could call down whenever it thinks the scale factor *might* have changed.

[Adam Roben (:aroben)]

Created attachment 104246 [details]
Make WebCore keep track of the current device scale factor

[WebKit Review Bot]

Attachment 104246 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/MediaQueryEvaluator.cpp:296:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

It would be great if some Qt folks could take a look at the changes to QWebPage just to make sure I'm not changing your API headers in a bad way. Thanks!

[Kenneth Rohde Christiansen]

Comment on attachment 104246 [details]
Make WebCore keep track of the current device scale factor

View in context: https://bugs.webkit.org/attachment.cgi?id=104246&action=review

> Source/WebKit/qt/Api/qwebpage.cpp:2571
> -    d->pixelRatio = conf.devicePixelRatio;
> +    d->page->setDeviceScaleFactor(conf.devicePixelRatio);

This is OK for now. We are doing this slightly different for WebKit2 anyway.

[Alexis Menard (darktears)]

Comment on attachment 104246 [details]
Make WebCore keep track of the current device scale factor

LGTM.

[Adam Roben (:aroben)]

Thanks!

[Adam Roben (:aroben)]

Committed r93303: <http://trac.webkit.org/changeset/93303>