| Summary: | Links to Trac from TestFailures page don't always show all relevant revisions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
| Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dbates, ddkilzer | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Adam Roben (:aroben)
2011-08-17 06:38:13 PDT
Created attachment 104168 [details]
Patch
Comment on attachment 104168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104168&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:140 > + limit: endRevision - startRevision + 2, // For some reason, Trac requires limit to be 5 in order to display 4 revisions (e.g.). What's the example? (since you mentioned "(e.g.)"). I would suggest mentioning the Trac version we are using (0.11.7) in this comment so as to provide a bit more context on this Trac bug. Even better, if we know the Trac ticket associated with this issue then we should list it in this comment (*). Do we know if this bug has been resolved in a newer version of Trac, say Trac 0.12? We could also file a WebKit bug to track this Trac issue. (*) <http://trac.edgewall.org/report/> Comment on attachment 104168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104168&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:140 >> + limit: endRevision - startRevision + 2, // For some reason, Trac requires limit to be 5 in order to display 4 revisions (e.g.). > > What's the example? (since you mentioned "(e.g.)"). I would suggest mentioning the Trac version we are using (0.11.7) in this comment so as to provide a bit more context on this Trac bug. Even better, if we know the Trac ticket associated with this issue then we should list it in this comment (*). Do we know if this bug has been resolved in a newer version of Trac, say Trac 0.12? We could also file a WebKit bug to track this Trac issue. > > (*) <http://trac.edgewall.org/report/> The example is what I mentioned in the comment: limit must be 5 in order to display 4 revisions. I could have also mentioned that limit must be 13 in order to display 11 revisions, etc. Do you have a suggestion for how to make this clearer? I filed http://trac.edgewall.org/ticket/10317 about this issue. It does not seem to be fixed in newer versions of Trac. (In reply to comment #3) > (From update of attachment 104168 [details]) > The example is what I mentioned in the comment: limit must be 5 in order to display 4 revisions. I could have also mentioned that limit must be 13 in order to display 11 revisions, etc. Do you have a suggestion for how to make this clearer? I just suggest referencing the Trac ticket in the comment now that you filed one. I realized your comment was the example. I'm not familiar with your usage of "e.g" . The form I'm familiar with is e.g. [example], where [example] is the example test. > > I filed http://trac.edgewall.org/ticket/10317 about this issue. It does not seem to be fixed in newer versions of Trac. Thanks for filing this. I'm sure Trac is happy as well. Committed r93224: <http://trac.webkit.org/changeset/93224> |