Bug 66356 – Represent RenderStyle::textOverflow property using an enum instead of a bool.

• Component: New Bugs
• Status: RESOLVED FIXED

[Luke Macpherson]

Represent RenderStyle::textOverflow property using an enum instead of a bool.

[Luke Macpherson]

Created attachment 104130 [details]
Patch

Comment on attachment 104130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104130&action=review

It would be nicer if you also changed the one or two places in rendering code that query this property to use the enum.

> Source/WebCore/rendering/style/RenderStyleConstants.h:437
> +enum TextOverflow { TextOverflowClip = 0, TextOverflowEllipsis };

Why the = 0?

[Luke Macpherson]

Comment on attachment 104130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104130&action=review

>> Source/WebCore/rendering/style/RenderStyleConstants.h:437
>> +enum TextOverflow { TextOverflowClip = 0, TextOverflowEllipsis };
> 
> Why the = 0?

Existing code does if (style()->textOverflow()), so it's a good idea to make the behavior of a cast from TextOverflow to boolean explicit.

[WebKit Review Bot]

Comment on attachment 104130 [details]
Patch

Clearing flags on attachment: 104130

Committed r93195: <http://trac.webkit.org/changeset/93195>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.