Bug 66347

Summary:

Switch html/* to to new layout types

Product:

WebKit

Reporter:

Emil A Eklund <eae>

Component:

Layout and Rendering

Assignee:

Emil A Eklund <eae>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, leviw, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

63567

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Emil A Eklund 2011-08-16 16:15:03 PDT

Convert HTML* and shadow element to new layout abstraction as a part of the ongoing conversion work.

Comment 1 Emil A Eklund 2011-08-16 17:03:29 PDT

Created attachment 104121 [details]
Patch

Comment 2 Eric Seidel (no email) 2011-08-17 11:10:10 PDT

Comment on attachment 104121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104121&action=review

> Source/WebCore/html/HTMLAreaElement.cpp:78
> -    m_lastSize = IntSize(-1, -1);
> +    m_lastSize = LayoutSize(-1, -1);

I wonder if this -1 -1 size needs to be a constant in this file.

> Source/WebCore/rendering/RenderImage.cpp:443
> +            if (scaleFactor != 1.0f)
> +                mapLocation.scale(scaleFactor, scaleFactor);

The if isn't really necessary. :)

Comment 3 Emil A Eklund 2011-08-17 12:04:58 PDT

Created attachment 104208 [details]
Patch for landing

Comment 4 WebKit Review Bot 2011-08-17 20:38:20 PDT

Comment on attachment 104208 [details]
Patch for landing

Clearing flags on attachment: 104208

Committed r93279: <http://trac.webkit.org/changeset/93279>

Comment 5 WebKit Review Bot 2011-08-17 20:38:24 PDT

All reviewed patches have been landed.  Closing bug.