Bug 66342

Summary: Add basic scripting support to the test movie plug-in
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED INVALID    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2011-08-16 15:34:53 PDT
Add basic scripting support to the test movie plug-in
Attachments
Patch (17.90 KB, patch)
2011-08-16 15:36 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-08-16 15:36:09 PDT
Created attachment 104102 [details] Patch
Sam Weinig
Comment 2 2011-08-16 15:43:09 PDT
Comment on attachment 104102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104102&action=review Fix the license and add more comment please. > Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:57 > + NPObject npObject; > + > + QTMovie *movie; Unnecessary newline. > Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:77 > +static NPObject *movieNPObjectAllocate(NPP npp, NPClass *theClass) * on the wrong side. > Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:99 > +static bool movieNPObjectHasMethod(NPObject *obj, NPIdentifier name) * on the wrong side, > Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:103 > + for (int i = 0; i < NUM_METHOD_IDENTIFIERS; i++) > + if (name == methodIdentifiers[i]) > + return true; Needs braces.
Note You need to log in before you can comment on or make changes to this bug.