Bug 6633

Summary: WebKit-no-SVG should be removed, replaced by using #if SVG_SUPPORT only
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
script to fix headers
none
script to fix source files
none
resulting patch
none
patch fixing a couple compile errors for SVG_SUPPORT andersca: review+

Eric Seidel (no email)
Reported 2006-01-17 18:39:23 PST
WebKit-no-SVG should be removed, replaced by using #if SVG_SUPPORT only All of the .cpp files in ksvg2 and kcanvas will need to be wrapped in #if SVG_SUPPORT. This will have to be placed after #include config.h so that config.h can control whether SVG_SUPPORT is used. We might need to wrapp the .h files as well, I'm not sure.
Attachments
script to fix headers (560 bytes, text/x-perl-script)
2006-01-22 05:25 PST, Eric Seidel (no email) 		no flags
Details
script to fix source files (564 bytes, text/x-perl-script)
2006-01-22 05:25 PST, Eric Seidel (no email) 		no flags
Details
resulting patch (347.07 KB, patch)
2006-01-22 05:29 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
patch fixing a couple compile errors for SVG_SUPPORT (348.46 KB, patch)
2006-01-22 05:55 PST, Eric Seidel (no email) 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2006-01-22 05:25:20 PST
Created attachment 5837 [details] script to fix headers
Eric Seidel (no email)
Comment 2 2006-01-22 05:25:41 PST
Created attachment 5838 [details] script to fix source files
Eric Seidel (no email)
Comment 3 2006-01-22 05:29:00 PST
Created attachment 5839 [details] resulting patch This patch removes the WebCore-no-svg target, and wraps all SVG specific files in #if SVG_SUPPORT, usign the attached scripts.
Eric Seidel (no email)
Comment 4 2006-01-22 05:55:42 PST
Created attachment 5840 [details] patch fixing a couple compile errors for SVG_SUPPORT
Anders Carlsson
Comment 5 2006-01-22 06:04:15 PST
Comment on attachment 5840 [details] patch fixing a couple compile errors for SVG_SUPPORT r=me
Note You need to log in before you can comment on or make changes to this bug.