Summary: | Support reset in WebCore::Internals | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||||||
Component: | Tools / Tests | Assignee: | Chang Shu <cshu> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, dglazkov, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 66052 | ||||||||||
Attachments: |
|
Description
Chang Shu
2011-08-16 08:24:20 PDT
Created attachment 104054 [details]
fix patch
The patch works for mac and qt.
Attachment 104054 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/testing/js/WebCoreTestSupport.cpp:59: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 104054 [details]
fix patch
This is a great start. We shouldn't land this with partial port support though. Cross-port support is the whole point of window.internals.
Created attachment 104078 [details]
fix patch 2
Comment on attachment 104078 [details] fix patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=104078&action=review > Source/WebCore/testing/js/WebCoreTestSupport.cpp:54 > + Internals * internals = toInternals(globalObject->getDirect(exec->globalData(), Identifier(exec, "internals"))); Now that we're using it in more than one place, the literal should probably be a constant in this file. > Source/WebCore/testing/v8/WebCoreTestSupport.cpp:53 > + v8::Handle<v8::Object> object = v8::Handle<v8::Object>::Cast(context->Global()->Get(v8::String::New("internals"))); Ditto. Created attachment 104200 [details]
patch 3: reviewed with minor fix
Manually committed r93235: <http://trac.webkit.org/changeset/93235> Clearing flags. |