Summary: | Apple's Windows port matches Lion for some test results, but doesn't use Lion results | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, ddkilzer, sam, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-08-16 07:58:26 PDT
Created attachment 104042 [details]
Patch
Created attachment 104043 [details]
Make Apple's Windows port fall back to Lion results instead of SnowLeopard
Comment on attachment 104043 [details] Make Apple's Windows port fall back to Lion results instead of SnowLeopard View in context: https://bugs.webkit.org/attachment.cgi?id=104043&action=review r=me > Tools/Scripts/webkitpy/common/config/build_unittest.py:43 > + (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]), Nit: I would have sub-ordered the mac-* ports by release: mac-leopard, mac-snowleopard, mac-lion, win Comment on attachment 104043 [details] Make Apple's Windows port fall back to Lion results instead of SnowLeopard View in context: https://bugs.webkit.org/attachment.cgi?id=104043&action=review >> Tools/Scripts/webkitpy/common/config/build_unittest.py:43 >> + (["LayoutTests/platform/mac-lion/foo"], ["mac-leopard", "mac-lion", "mac-snowleopard", "win"]), > > Nit: I would have sub-ordered the mac-* ports by release: mac-leopard, mac-snowleopard, mac-lion, win Everything else is sorted lexicographically. I think we might as well maintain that here, too. Silly Apple for not naming releases alphabetically! Committed r93107: <http://trac.webkit.org/changeset/93107> |