ScrollAnimatorNone coasting implementation

• Component: New Bugs
• Status: RESOLVED FIXED

[Scott Byer]

ScrollAnimatorNone coasting implementation

[Scott Byer]

Created attachment 103972 [details]
Patch

[Scott Byer]

Created attachment 104371 [details]
Patch

[Scott Byer]

Rebased. James, if you have a chance, could you review this? It's slightly big, but is mostly tests. As always, feel free to point me at someone else.

[Scott Byer]

Created attachment 104378 [details]
Patch

[James Robinson]

Comment on attachment 104378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104378&action=review

> Source/WebCore/platform/ScrollAnimatorNone.cpp:141
> +        double t1 = std::min(t, 1 / 2.75);

In WebKit, we prefer to put a 'using namespace std' at the top of the file and use the name unqualified.

Where are all of these magical numbers coming from?  Is it possible to give them useful symbolic names? They seem a little precise to be completely arbitrary.

> Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp:416
> +    for (double t = .25 ; t < 1 ; t += .25) {

nit: odd spacing here, i wouldn't expect a space before the ;

[Scott Byer]

Created attachment 104425 [details]
Address review comments

[Scott Byer]

PTAL, I've cleaned up the style issues and rebased. Thanks.

[James Robinson]

Comment on attachment 104425 [details]
Address review comments

Looks great, thanks for explaining some of the math in comments.

[WebKit Review Bot]

Comment on attachment 104425 [details]
Address review comments

Clearing flags on attachment: 104425

Committed r93682: <http://trac.webkit.org/changeset/93682>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.