Bug 66255

Summary: Move LayoutRepainter to its own class
Product: WebKit Reporter: Julien Chaffraix <jchaffraix>
Component: Layout and RenderingAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Minor CC: morrita, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed change: Move the code to a new class for easier hacking.
none
Patch 2: Fixed windows build per Hajime's comment. morrita: review+, webkit.review.bot: commit-queue-

Julien Chaffraix
Reported 2011-08-15 14:44:53 PDT
The class is part of RenderObject currently which makes it difficult to change and could easily introduce cyclic or unwanted dependencies with RenderObject.
Attachments
Proposed change: Move the code to a new class for easier hacking. (22.13 KB, patch)
2011-08-15 15:47 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Patch 2: Fixed windows build per Hajime's comment. (22.74 KB, patch)
2011-08-25 10:26 PDT, Julien Chaffraix 		morrita: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-08-15 15:47:25 PDT
Created attachment 103968 [details] Proposed change: Move the code to a new class for easier hacking.
Hajime Morrita
Comment 2 2011-08-23 04:10:01 PDT
Comment on attachment 103968 [details] Proposed change: Move the code to a new class for easier hacking. View in context: https://bugs.webkit.org/attachment.cgi?id=103968&action=review LayoutRepainter.cpp should be RenderingAllInOne.cpp to make Windows build to pass. > Source/WebCore/rendering/RenderObject.h:117 > + friend class LayoutRepainter; Why do we need this?
Julien Chaffraix
Comment 3 2011-08-25 10:26:57 PDT
Created attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment.
Hajime Morrita
Comment 4 2011-08-30 21:02:45 PDT
Comment on attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment. I'm sorry for the slow response.
Julien Chaffraix
Comment 5 2011-08-31 10:21:47 PDT
Comment on attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment. Thanks Hajime!
WebKit Review Bot
Comment 6 2011-08-31 11:26:16 PDT
Comment on attachment 105210 [details] Patch 2: Fixed windows build per Hajime's comment. Rejecting attachment 105210 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: e-document-url.html = TEXT TIMEOUT PASS Regressions: Unexpected image and text mismatch : (1) svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Full output: http://queues.webkit.org/results/9553008
Julien Chaffraix
Comment 7 2011-09-01 17:29:05 PDT
Committed r94372: <http://trac.webkit.org/changeset/94372>
Note You need to log in before you can comment on or make changes to this bug.