Summary: | It's hard to tell what the actual result of a failed JS test is in TestWebKitAPI's output | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, dslomov, levin, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-08-15 11:15:28 PDT
Created attachment 103929 [details]
Patch
Comment on attachment 103929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103929&action=review > Tools/TestWebKitAPI/JavaScriptTest.cpp:79 > + OwnArrayPtr<char> buffer = adoptArrayPtr(new char[bufferSize]); Interestingly JSStringGetMaximumUTF8CStringSize seems incorrectly used in WebKit/Tools/DumpRenderTree/LayoutTestController.cpp where it adds +1 to the output from it but looking at the implementation of that function. the usage here is correct. Committed r93052: <http://trac.webkit.org/changeset/93052> |