Bug 66240

Summary: It's hard to tell what the actual result of a failed JS test is in TestWebKitAPI's output
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dslomov, levin, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch levin: review+

Adam Roben (:aroben)
Reported 2011-08-15 11:15:28 PDT
It's hard to tell what the actual result of a failed JS test is in TestWebKitAPI's output
Attachments
Patch (10.39 KB, patch)
2011-08-15 11:16 PDT, Adam Roben (:aroben) 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-08-15 11:16:39 PDT
Created attachment 103929 [details] Patch
David Levin
Comment 2 2011-08-15 11:34:19 PDT
Comment on attachment 103929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103929&action=review > Tools/TestWebKitAPI/JavaScriptTest.cpp:79 > + OwnArrayPtr<char> buffer = adoptArrayPtr(new char[bufferSize]); Interestingly JSStringGetMaximumUTF8CStringSize seems incorrectly used in WebKit/Tools/DumpRenderTree/LayoutTestController.cpp where it adds +1 to the output from it but looking at the implementation of that function. the usage here is correct.
Adam Roben (:aroben)
Comment 3 2011-08-15 12:31:16 PDT
Committed r93052: <http://trac.webkit.org/changeset/93052>
Note You need to log in before you can comment on or make changes to this bug.