Bug 66225

Summary:

Web Inspector: switch to using BreakpointHelper.

Product:

WebKit

Reporter:

Pavel Podivilov <podivilov>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Podivilov <podivilov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ec2-cr-linux-02	none
Patch	pfeldman: review+

Pavel Podivilov

Reported 2011-08-15 07:36:45 PDT

Web Inspector: switch to using BreakpointHelper. See https://bugs.webkit.org/show_bug.cgi?id=66224.

Attachments
Patch (20.46 KB, patch) 2011-08-15 07:38 PDT, Pavel Podivilov	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-02 (3.91 MB, application/zip) 2011-08-15 11:34 PDT, WebKit Review Bot	no flags	Details
Patch (20.30 KB, patch) 2011-08-19 09:06 PDT, Pavel Podivilov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Podivilov

Comment 1 2011-08-15 07:38:15 PDT

Created attachment 103913 [details] Patch

WebKit Review Bot

Comment 2 2011-08-15 11:34:10 PDT

Comment on attachment 103913 [details] Patch Attachment 103913 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9378788 New failing tests: http/tests/inspector/console-xhr-logging.html http/tests/inspector/network/network-cachedresources-with-same-urls.html http/tests/inspector/console-cd.html http/tests/inspector/network/network-disable-cache-memory.html http/tests/inspector/resource-har-headers.html http/tests/inspector/network/network-clear-after-disabled.html http/tests/inspector/network/download.html http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html http/tests/inspector/inspect-iframe-from-different-domain.html http/tests/inspector-enabled/console-log-before-frame-navigation.html http/tests/inspector/network-preflight-options.html http/tests/inspector/network/network-content-replacement-xhr.html http/tests/inspector/network/network-close-load-open.html http/tests/inspector-enabled/dom-storage-open.html http/tests/inspector/resource-har-conversion.html http/tests/inspector/console-resource-errors.html http/tests/inspector/resource-parameters.html http/tests/inspector-enabled/database-open.html http/tests/inspector/console-cd-completions.html http/tests/inspector/change-iframe-src.html

WebKit Review Bot

Comment 3 2011-08-15 11:34:19 PDT

Created attachment 103932 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Pavel Podivilov

Comment 4 2011-08-19 09:06:30 PDT

Created attachment 104515 [details] Patch

Pavel Feldman

Comment 5 2011-08-23 01:53:52 PDT

Comment on attachment 104515 [details] Patch This.is.scary.

Pavel Podivilov

Comment 6 2011-08-23 05:43:56 PDT

Committed r93595: <http://trac.webkit.org/changeset/93595>

Note You need to log in before you can comment on or make changes to this bug.