Bug 66204 – garden-o-matic should be able to rebaseline expected failures

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Barth]

garden-o-matic should be able to rebaseline expected failures

[Adam Barth]

Created attachment 103877 [details]
work-in-progress (breaks garden-o-matic)

[Adam Barth]

Noel asked for this feature.  (Also, this gives me an opportunity to re-build the results detail view using our fancy object-oriented toolkit.)

[Adam Barth]

@dglakov: Thoughts on how to upcall from views to controllers?  This patch uses two approaches:

1) Direct function calls on a controller object (e.g., to fetch information from the network).
2) onFooBar properties, which can be overridden to observe events.

Instead of onFooBar properties, we could use honest-to-goodness DOM events (e.g., triggering them with http://api.jquery.com/trigger/ or manually).

[Dimitri Glazkov (Google)]

(In reply to comment #3)
> @dglakov: Thoughts on how to upcall from views to controllers?  This patch uses two approaches:
> 
> 1) Direct function calls on a controller object (e.g., to fetch information from the network).
> 2) onFooBar properties, which can be overridden to observe events.
> 
> Instead of onFooBar properties, we could use honest-to-goodness DOM events (e.g., triggering them with http://api.jquery.com/trigger/ or manually).

Firing/listening to events sounds nice and easy to do:

var event = document.createEvent("Event");
event.initEvent("TheRooTheRoofTheRoof", false, false);
event.isOn = "fire";
target.dispatchEvent(event);

[Adam Barth]

Created attachment 103971 [details]
more work

[Adam Barth]

Created attachment 104197 [details]
Machine transfer

[Adam Barth]

Created attachment 104213 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 104213 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=104213&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js:30
> +contollers.resultsDetails = base.extends(Object, {

ResultsDetails

[Adam Barth]

Committed r93236: <http://trac.webkit.org/changeset/93236>