Bug 66195

Summary: webkit-indent-blockquote is unnecessary
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, justin.garcia, leviw, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fixes the bug none

Ryosuke Niwa
Reported 2011-08-13 12:33:28 PDT
WebKit currently adds class="webkit-indent-blockquote" in IndentOutdentCommand, but this is unnecessary as we no longer checks whether this class is present or not. We should stop adding this classname for the sake of less verbose markup and to be consistent with other browsers.
Attachments
fixes the bug (21.14 KB, patch)
2011-08-13 12:39 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-08-13 12:39:09 PDT
Created attachment 103868 [details] fixes the bug
Ryosuke Niwa
Comment 2 2011-08-13 12:42:45 PDT
http://trac.webkit.org/changeset/45886 is the revision that changed WebKit's behavior to always remove blockquote regardless of the presence of webkit-indent-blockquote. Before this revision, WebKit was unable to remove blockquotes without the said classname.
Ryosuke Niwa
Comment 3 2011-08-13 12:51:37 PDT
Now that I think about it, style attribute is also unnecessary in most cases. We should probably check the context into which blockquotes are inserted and add margin, padding, and border properties only if they are necessary.
Ryosuke Niwa
Comment 4 2011-08-15 11:20:15 PDT
Comment on attachment 103868 [details] fixes the bug Thanks for the review, Tony.
WebKit Review Bot
Comment 5 2011-08-15 12:23:42 PDT
Comment on attachment 103868 [details] fixes the bug Clearing flags on attachment: 103868 Committed r93051: <http://trac.webkit.org/changeset/93051>
WebKit Review Bot
Comment 6 2011-08-15 12:23:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.