Bug 66148
| Summary: | Replace == comparison with epsilon aware roughlyEquals for LayoutUnits | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, hyatt, leviw, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 63656 | ||
Emil A Eklund
Once we move to float we can no longer safely use == to compare two LayoutUnits.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
So, are we decided that we move to floats, not to fixed precision numbers?
Rough equality has a number of highly undesirable features - it's not transitive, it breaks with zoom etc.
Emil A Eklund
No firm decision yet, we have a prototype running on trunk that we are running a set of tests against to see if it's feasible to use floats throughout and help us discover problems.
We're currently leaning towards using floats as both javascript and the graphics sub system operates on floating point but we'll revisit this before committing to go down that path.
This bug is for tracking places where we might need to change how we do comparisons if we decide to go with floats.
Emil A Eklund
No longer applicable as we decided to go with fixed point.