Bug 66147

Summary: Switch FrameView to to new layout types
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, fsamuel, leviw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-08-12 10:48:42 PDT
Convert *** to new layout abstraction.
Attachments
Patch (40.45 KB, patch)
2011-08-15 14:25 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (40.45 KB, patch)
2011-08-15 16:30 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (40.41 KB, patch)
2011-08-15 17:54 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (40.43 KB, patch)
2011-08-17 12:17 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-08-15 14:25:19 PDT
Created attachment 103953 [details] Patch
Emil A Eklund
Comment 2 2011-08-15 16:30:18 PDT
Created attachment 103976 [details] Patch Re-uploading for ews.
Emil A Eklund
Comment 3 2011-08-15 17:54:10 PDT
Created attachment 103988 [details] Patch
Eric Seidel (no email)
Comment 4 2011-08-17 11:28:42 PDT
Comment on attachment 103988 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103988&action=review Please ping me over IRC if I don't notice your patches wihtin a couple hours of posting. I'm not reading email that regularly at the moment as I'm focusing on codding. > Source/WebCore/page/FrameView.cpp:2217 > + return LayoutRect(LayoutPoint(0, 0), contentsSize()); The 0, 0 isn't needed.
Emil A Eklund
Comment 5 2011-08-17 12:17:34 PDT
Created attachment 104210 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-08-17 21:06:19 PDT
Comment on attachment 104210 [details] Patch for landing Clearing flags on attachment: 104210 Committed r93280: <http://trac.webkit.org/changeset/93280>
WebKit Review Bot
Comment 7 2011-08-17 21:06:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.