Bug 66111

Summary: Make some GraphicsLayer functions pure virtual
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: cmarrin, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch sam: review-, gyuyoung.kim: commit-queue-

Noam Rosenthal
Reported 2011-08-11 15:51:53 PDT
Some of the functions in GraphicsLayer.h are used by many ports, but are overridable (virtual, non-pure). This makes it hard to detect when changes to those functions' signature is made. See https://bugs.webkit.org/show_bug.cgi?id=66108 for an example.
Attachments
Patch (1.61 KB, patch)
2011-08-11 15:54 PDT, Noam Rosenthal 		sam: review-
gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2011-08-11 15:54:42 PDT
Created attachment 103693 [details] Patch
Gyuyoung Kim
Comment 2 2011-08-11 16:03:29 PDT
Comment on attachment 103693 [details] Patch Attachment 103693 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9357395
WebKit Review Bot
Comment 3 2011-08-11 16:13:15 PDT
Comment on attachment 103693 [details] Patch Attachment 103693 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9348378
Early Warning System Bot
Comment 4 2011-08-11 16:17:53 PDT
Comment on attachment 103693 [details] Patch Attachment 103693 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9358387
WebKit Review Bot
Comment 5 2011-08-11 18:03:50 PDT
Comment on attachment 103693 [details] Patch Attachment 103693 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9352385
Sam Weinig
Comment 6 2011-08-11 18:06:21 PDT
Comment on attachment 103693 [details] Patch This seems to break things. r-
Note You need to log in before you can comment on or make changes to this bug.