Summary: | JSC verbose debugging output sometimes doesn't work as expected. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Filip Pizlo
2011-08-11 15:38:14 PDT
Created attachment 103688 [details]
the patch
Comment on attachment 103688 [details]
the patch
tests pass.
Comment on attachment 103688 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=103688&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:549 > + printf("bad_regexp(%d)\n", re0); There is something a little odd about making our dumping robust against bad regexp numbers here, since I don't think we're robust against other forms of bad bytecode in dumping. Still, this is debug code, if this is helpful, sure! why not! Comment on attachment 103688 [details] the patch Clearing flags on attachment: 103688 Committed r93238: <http://trac.webkit.org/changeset/93238> All reviewed patches have been landed. Closing bug. Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. |