|Summary:||JSC verbose debugging output sometimes doesn't work as expected.|
|Product:||WebKit||Reporter:||Filip Pizlo <fpizlo>|
|Version:||528+ (Nightly build)|
Description Filip Pizlo 2011-08-11 15:38:14 PDT
There are a few holes in our verbose debugging output: CodeBlock::dump(): - Will crash when printing JSCell constants, if converting them to string requires calling into JS code. - Will crash on op_new_regexp because of an out-of-bounds. DFG verbose mode: - Reports only the bottom address of generated code, and not the top, making it somewhat harder to mentally map executing code to the debug dumps.
Comment 2 Filip Pizlo 2011-08-11 15:58:49 PDT
Comment on attachment 103688 [details] the patch tests pass.
Comment 3 Gavin Barraclough 2011-08-17 12:56:22 PDT
Comment 4 WebKit Review Bot 2011-08-17 13:54:46 PDT
Comment on attachment 103688 [details] the patch Clearing flags on attachment: 103688 Committed r93238: <http://trac.webkit.org/changeset/93238>
Comment 5 WebKit Review Bot 2011-08-17 13:54:50 PDT
All reviewed patches have been landed. Closing bug.
Comment 6 Darin Adler 2014-04-24 16:45:23 PDT