Bug 6609

Summary: Use Selection instead of SelectionController where possible
Product: WebKit Reporter: Duncan Wilcox <duncan>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch darin: review+

Duncan Wilcox
Reported 2006-01-16 23:43:12 PST
This patch replaces the use of SelectionController with Selection in the edit commands. It also cleans up the relationship between Selection and SelectionController: SelectionController used to need to be friend to Selection to call validate() on it, now validation is enforced on every update of Selection.
Attachments
patch (34.51 KB, patch)
2006-01-16 23:43 PST, Duncan Wilcox 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Duncan Wilcox
Comment 1 2006-01-16 23:43:43 PST
Created attachment 5733 [details] patch
Darin Adler
Comment 2 2006-01-17 00:31:28 PST
Comment on attachment 5733 [details] patch Looks great, r=me.
Note You need to log in before you can comment on or make changes to this bug.