Bug 66089

Summary: Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: New BugsAssignee: Fady Samuel <fsamuel>
Status: RESOLVED WONTFIX    
Severity: Normal CC: abarth, dglazkov, eric, fishd, fsamuel, rjkroege, schenney, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 66155    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Fady Samuel
Reported 2011-08-11 13:11:20 PDT
Chromium's WebKit API should use floats instead of doubles for zoom to match WebCore
Attachments
Patch (7.21 KB, patch)
2011-08-11 13:11 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-08-11 13:11:41 PDT
Created attachment 103659 [details] Patch
WebKit Review Bot
Comment 2 2011-08-11 13:57:19 PDT
Comment on attachment 103659 [details] Patch Attachment 103659 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9371151
WebKit Review Bot
Comment 3 2011-08-12 11:43:50 PDT
Comment on attachment 103659 [details] Patch Clearing flags on attachment: 103659 Committed r92978: <http://trac.webkit.org/changeset/92978>
WebKit Review Bot
Comment 4 2011-08-12 11:43:55 PDT
All reviewed patches have been landed. Closing bug.
Fady Samuel
Comment 5 2011-08-24 13:54:40 PDT
This was reverted, but I can't figure out why? Will try to recommit...and keep an eye on what breaks...if anything..Adam?
Eric Seidel (no email)
Comment 6 2012-02-16 14:33:02 PST
What's the status here. Did this get re-landed? Does this need another review?
Ojan Vafai
Comment 7 2012-04-19 15:34:25 PDT
Comment on attachment 103659 [details] Patch It was rolled out because it doesn't compile apparently: http://trac.webkit.org/changeset/92980, but the EWS bots seem green now, so maybe whatever the problem was is resolved. Will try cq+ on it again.
WebKit Review Bot
Comment 8 2012-04-19 15:36:55 PDT
Comment on attachment 103659 [details] Patch Rejecting attachment 103659 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: . Hunk #4 succeeded at 2210 (offset 355 lines). patching file Source/WebKit/chromium/src/WebViewImpl.h Hunk #1 FAILED at 151. Hunk #2 succeeded at 507 with fuzz 2 (offset 118 lines). Hunk #3 succeeded at 657 with fuzz 2 (offset 170 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Ojan Vafai']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12297453
Note You need to log in before you can comment on or make changes to this bug.