Bug 66054

Summary: [Qt] PageSerializer is specific to MHTML, we should not compile it
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: jcivelli, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-08-11 06:43:44 PDT
The compilation time is already slow enough to not compile files for fun ;)
Attachments
Patch (1.94 KB, patch)
2011-08-11 07:05 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-08-11 07:05:40 PDT
Created attachment 103617 [details] Patch
Benjamin Poulain
Comment 2 2011-08-11 07:12:29 PDT
Jay, what is your intention with PageSerializer? Does this patch make sense or you plan to use the class elsewhere?
Jay Civelli
Comment 3 2011-08-11 09:24:21 PDT
It is safe to remove it from the Qt build if you don't need MHTML support. There is no plan I am aware of to use it anywhere else at this time.
Benjamin Poulain
Comment 4 2011-08-11 09:27:28 PDT
Comment on attachment 103617 [details] Patch (In reply to comment #3) > It is safe to remove it from the Qt build if you don't need MHTML support. > There is no plan I am aware of to use it anywhere else at this time. Cool, thanks for looking at this.
WebKit Review Bot
Comment 5 2011-08-11 09:38:07 PDT
Comment on attachment 103617 [details] Patch Clearing flags on attachment: 103617 Committed r92856: <http://trac.webkit.org/changeset/92856>
WebKit Review Bot
Comment 6 2011-08-11 09:38:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.