Bug 66022

Summary: Only set m_fontDirty if TextSizeAdjust is actually changed.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, macpherson, mitz, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Luke Macpherson
Reported 2011-08-10 17:07:15 PDT
Only set m_fontDirty if TextSizeAdjust is actually changed.
Attachments
Patch (3.78 KB, patch)
2011-08-10 17:13 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-08-10 17:13:21 PDT
Created attachment 103562 [details] Patch
Luke Macpherson
Comment 2 2011-08-16 16:21:56 PDT
Weekly ping. Please review this patch!
Darin Adler
Comment 3 2011-08-17 09:46:22 PDT
Comment on attachment 103562 [details] Patch Is there some way to test the performance benefit here? Maybe we could do a performance test that checks that changing the value back and forth and forcing style recalculation is significantly slower than setting the value to the same thing over and over again. It would be great to have a test like that!
WebKit Review Bot
Comment 4 2011-08-17 10:45:58 PDT
Comment on attachment 103562 [details] Patch Clearing flags on attachment: 103562 Committed r93218: <http://trac.webkit.org/changeset/93218>
WebKit Review Bot
Comment 5 2011-08-17 10:46:02 PDT
All reviewed patches have been landed. Closing bug.
Luke Macpherson
Comment 6 2011-08-17 16:10:55 PDT
Even if this were slower I think it would be worth doing. When I first started touching the m_fontDirtry logic it was really because I wanted it to not be spread all over the place, because I figured it would be too easy to accidentally not set m_fontDirty. It still is, but at least the logic is constrained to fewer places. Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.