Bug 65977 – [Qt] Page is getting loaded continuously in the attached reduced page

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Ritesh]

Created attachment 103472 [details]
Reduced page for the mentioned bug

Steps to reproduce:
1. Load the attached reduced page

Expected Result - Page should load fine

Actual Result -
Page loaded fine in Mozilla (Firefox for Ubuntu 3.6.18) and Chrome but page is getting loaded continuously on Mini Browser and QtTestBrowser in the nightly build.

[Zeno Albisser]

Created attachment 107180 [details]
patch for review.

[WebKit Review Bot]

Comment on attachment 107180 [details]
patch for review.

Rejecting attachment 107180 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Comment on attachment 107180 [details]
patch for review.

Rejecting attachment 107180 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Chang Shu]

Comment on attachment 107180 [details]
patch for review.

You need to add your attached test page to layout tests. r- for that. Please also run the entire (at least related) layout tests to make sure no regression is introduced.

[Zeno Albisser]

Created attachment 107200 [details]
patch for review - added unit test

[Chang Shu]

Comment on attachment 107200 [details]
patch for review - added unit test

View in context: https://bugs.webkit.org/attachment.cgi?id=107200&action=review

good, please fix the typo, etc. before landing.

> Source/WebKit/qt/ChangeLog:10
> +        Therefor a subresourceLoader can still be active, when we receive the

typo: Therefore

> Source/WebKit/qt/ChangeLog:13
> +        This changeset fixes the described behavior by updating the action states

described behavior => inconsistent state

> Source/WebKit/qt/tests/qwebpage/resources/script.html:2
> +<script language="javascript" type="text/javascript" src="nothing.js"></script>

I think "does_not_exist.js" is better than "nothing.js".

[Zeno Albisser]

Created attachment 107224 [details]
patch for review - fixed typos and wording

Thanks for the feedback. :-)

[WebKit Review Bot]

Comment on attachment 107224 [details]
patch for review - fixed typos and wording

Clearing flags on attachment: 107224

Committed r95055: <http://trac.webkit.org/changeset/95055>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Zeno Albisser]

*** Bug 65983 has been marked as a duplicate of this bug. ***