Bug 65887

Summary: handle child margin values when flexing
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, hyatt, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch
none
Patch hyatt: review+

Description Tony Chang 2011-08-08 16:13:25 PDT 
handle child margin values when flexing
Comment 1 Tony Chang 2011-08-08 16:15:18 PDT 
Created attachment 103309 [details]
Patch
Comment 2 Gyuyoung Kim 2011-08-08 16:18:34 PDT 
Comment on attachment 103309 [details]
Patch

Attachment 103309 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9335146
Comment 3 WebKit Review Bot 2011-08-08 16:19:58 PDT 
Comment on attachment 103309 [details]
Patch

Attachment 103309 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9330634
Comment 4 Early Warning System Bot 2011-08-08 16:22:09 PDT 
Comment on attachment 103309 [details]
Patch

Attachment 103309 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9332197
Comment 5 Tony Chang 2011-08-08 16:22:44 PDT 
Created attachment 103310 [details]
Patch
Comment 6 Dave Hyatt 2011-08-22 10:39:13 PDT 
Comment on attachment 103310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103310&action=review

> Source/WebCore/rendering/RenderBox.cpp:1637
> +#if ENABLE(CSS3_FLEXBOX)
> +            && !cb->isFlexibleBox()
> +#endif
> +            && !cb->isDeprecatedFlexibleBox())

I imagine this will come up again, so it seems like a method that wrapped both of these would be useful. Then you don't have ifdefs at all the call sites either.
Comment 7 Tony Chang 2011-08-22 11:18:02 PDT 
Created attachment 104700 [details]
Patch
Comment 8 Dave Hyatt 2011-08-22 13:33:09 PDT 
Comment on attachment 104700 [details]
Patch

r=me
Comment 9 Tony Chang 2011-08-22 14:49:16 PDT 
Committed r93547: <http://trac.webkit.org/changeset/93547>