Summary: | [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED INVALID | ||||||
Severity: | Normal | CC: | ademar, kling, laszlo.gombos, ossy, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 65921 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Siddharth Mathur
2011-08-08 15:08:16 PDT
Created attachment 103304 [details]
Clean up code
Qt 4.7+ always provide QDesktopServices and QNetworkDiskCache.
Comment on attachment 103304 [details]
Clean up code
Yay for fewer untested flag combinations!
Comment on attachment 103304 [details] Clean up code Clearing flags on attachment: 103304 Committed r92683: <http://trac.webkit.org/changeset/92683> All reviewed patches have been landed. Closing bug. Reverted in Bug 65921 due to minimal build slave using a Qt which (IMHO) is too minimal: http://build.webkit.org/buildslaves/szeged-linux-2 Laszlo, when you are back from your vacation, can you advise Ossy on what configuration to use on that slave? Are QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE already removed from Qt (trunk) ? So what kind of Qt configuration we need on the minimal bot? === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. |