Bug 65880 – [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE

• Component: Platform
• Status: RESOLVED INVALID

[Siddharth Mathur]

QDesktopServices has been a part of QtGui since Qt 4.2 and QNetworkDiskCache a part of QtNetwork since Qt 4.5. Both have almost entirely platform-agnostic back-ends. 
Remove flags that try and toggle them from --minimal build configuration. 

After this patch lands, I will propose turning on QNetworkDiskCache in DRT. Using an HTTP cache exposes bugs in QtNetwork such as this one exposed via xhr/response-encoding.htm : 
https://bugreports.qt.nokia.com/browse/QTBUG-20796

[Siddharth Mathur]

Created attachment 103304 [details]
Clean up code

Qt 4.7+ always provide QDesktopServices and QNetworkDiskCache.

[Andreas Kling]

Comment on attachment 103304 [details]
Clean up code

Yay for fewer untested flag combinations!

[WebKit Review Bot]

Comment on attachment 103304 [details]
Clean up code

Clearing flags on attachment: 103304

Committed r92683: <http://trac.webkit.org/changeset/92683>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Siddharth Mathur]

Reverted in Bug 65921 due to minimal build slave using a Qt which (IMHO) is too minimal: 
http://build.webkit.org/buildslaves/szeged-linux-2

Laszlo, when  you are back from your vacation, can you advise Ossy on what configuration to use on that slave?

[Laszlo Gombos]

Are QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE already removed from Qt (trunk) ?

[Csaba Osztrogonác]

So what kind of Qt configuration we need on the minimal bot?

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.