Summary: | [chromium] Notify MemoryCache of decoded data access | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||
Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, jamesr, mnaganov, satish, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tony Gentilcore
2011-08-08 08:42:54 PDT
Created attachment 103256 [details]
Patch
Comment on attachment 103256 [details]
Patch
So win comes from this causing the side effect of pruning *other* data by marking this data as recently used?
(In reply to comment #2) > (From update of attachment 103256 [details]) > So win comes from this causing the side effect of pruning *other* data by marking this data as recently used? Yeah, properly populating the LRU so we prune wisely is half of it. The other half is just getting prune() to be called at all in cases like scrolling through a very large page of images where the decoded data doesn't fit within the target cache size. BTW, do you have any historical context here about why the chromium port doesn't do this like all the other ports? I'm curious if it is intentional or just an oversight. I couldn't dig up anything relevant in the ChangeLogs. Comment on attachment 103256 [details]
Patch
Yay!
Comment on attachment 103256 [details] Patch Clearing flags on attachment: 103256 Committed r92782: <http://trac.webkit.org/changeset/92782> All reviewed patches have been landed. Closing bug. |