Bug 65761

Summary:

Web Inspector: constrain maximum depth for returnByValue objects

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Yury Semikhatsky <yurys>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Yury Semikhatsky

Reported 2011-08-05 02:24:18 PDT

Result of evaluation may well be self referencing structure, we need to fail gracefully in that case if the evaluation was requested with returnByValue flag.

Attachments
Patch (12.81 KB, patch) 2011-08-05 02:27 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-08-05 02:27:48 PDT

Created attachment 103054 [details] Patch

Pavel Feldman

Comment 2 2011-08-05 02:32:01 PDT

Comment on attachment 103054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103054&action=review > Source/WebCore/inspector/InspectorValues.h:51 > + static const int maxDepth = 20; 1000?

Yury Semikhatsky

Comment 3 2011-08-05 02:35:19 PDT

(In reply to comment #2) > (From update of attachment 103054 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103054&action=review > > > Source/WebCore/inspector/InspectorValues.h:51 > > + static const int maxDepth = 20; > > 1000? Done.

Yury Semikhatsky

Comment 4 2011-08-05 02:38:36 PDT

Committed r92471: <http://trac.webkit.org/changeset/92471>

Note You need to log in before you can comment on or make changes to this bug.