Bug 65761

Summary: Web Inspector: constrain maximum depth for returnByValue objects
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+

Description Yury Semikhatsky 2011-08-05 02:24:18 PDT
Result of evaluation may well be self referencing structure, we need to fail gracefully in that case if the evaluation was requested with returnByValue flag.
Comment 1 Yury Semikhatsky 2011-08-05 02:27:48 PDT
Created attachment 103054 [details]
Patch
Comment 2 Pavel Feldman 2011-08-05 02:32:01 PDT
Comment on attachment 103054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103054&action=review

> Source/WebCore/inspector/InspectorValues.h:51
> +    static const int maxDepth = 20;

1000?
Comment 3 Yury Semikhatsky 2011-08-05 02:35:19 PDT
(In reply to comment #2)
> (From update of attachment 103054 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103054&action=review
> 
> > Source/WebCore/inspector/InspectorValues.h:51
> > +    static const int maxDepth = 20;
> 
> 1000?

Done.
Comment 4 Yury Semikhatsky 2011-08-05 02:38:36 PDT
Committed r92471: <http://trac.webkit.org/changeset/92471>