Bug 65760

Summary:

CSSSelector::selectorText should use StringBuilder instead of +=

Product:

WebKit

Reporter:

Oliver Varga <voliver>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abecsi, darin, morrita, rhodovan.u-szeged, shinyak, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	morrita: review-

Oliver Varga

Reported 2011-08-05 02:14:13 PDT

Attachments
Patch (13.54 KB, patch) 2011-08-29 23:09 PDT, Shinya Kawanaka	morrita: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Shinya Kawanaka

Comment 1 2011-08-29 23:09:36 PDT

Hajime Morrita

Comment 2 2011-10-02 22:25:04 PDT

Comment on attachment 105583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105583&action=review > Source/WebCore/css/CSSSelector.cpp:629 > if (CSSSelector* tagHistory = cs->tagHistory()) { How about just to return and eliminate temporal "str" ? Also, you can do early return by checking tagHistory != NULL.

Hajime Morrita

Comment 3 2011-10-02 22:27:13 PDT

Anyway, is it possible to eliminate whole "+" by moving the last block to the head of the function?

Renata Hodovan

Comment 4 2012-11-18 02:09:05 PST

It's already fixed in r126967;

Note You need to log in before you can comment on or make changes to this bug.