Bug 65756
| Summary: | Web Inspector: do not use InspectorFrontendClientLocal from within WebKit2 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, aroben, burg, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Pavel Feldman
Opening this bug for us to track the migration process. I'd suggest that we start as follows:
1) In WebInspectorClient::openInspectorFrontend(InspectorController*) establish binding between the WebInspectorClient and WebInspectorFrontendClient
2) Inline InspectorFrontendClientLocal in WebInspectorFrontendClient so that instead of InspectorFrontendClientLocal's abstract functions WebInspectorFrontendClient needed to implement the original interface (InspectorFrontendClientLocal is like 100 lines of boilerplate code)
3) Reimplement canAttach the right way
4) Get rid of InspectorController::setInspectorFrontendClient to avoid further confusions
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |