Bug 65747

Summary:

Remove LegacyDefaultOptionalArguments flag from notifications IDL files

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Mark Pilgrim (Google) 2011-08-04 22:16:50 PDT

As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates the notifications-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa.

All existing tests pass.

Comment 1 Mark Pilgrim (Google) 2011-08-04 22:17:25 PDT

Created attachment 103036 [details]
Patch

Comment 2 Adam Barth 2011-08-04 23:13:55 PDT

Comment on attachment 103036 [details]
Patch

Any sense for how far along we are?

Comment 3 WebKit Review Bot 2011-08-05 00:18:36 PDT

Comment on attachment 103036 [details]
Patch

Clearing flags on attachment: 103036

Committed r92454: <http://trac.webkit.org/changeset/92454>

Comment 4 WebKit Review Bot 2011-08-05 00:18:40 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Mark Pilgrim (Google) 2011-08-05 06:37:08 PDT

Only a handful left. Literally, less than 5.