| Summary: | [chromium] Rebaseline following r92255 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Reveman <reveman> | ||||||
| Component: | WebKit Misc. | Assignee: | David Reveman <reveman> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jamesr, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 65776 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
David Reveman
2011-08-04 18:15:36 PDT
Created attachment 103025 [details]
Patch
Rebaselines most of the tests affected by the new anti-aliasing method. The patch is missing a few win/mac test that don't seem to have results. Not sure how to handle that. Comment on attachment 103025 [details]
Patch
Thanks, these look OK. The banding on platform/chromium/compositing/huge-layer-rotated.html and platform/chromium/compositing/tiny-layer-rotated.html is really weird, but it seems that it's not new.
Comment on attachment 103025 [details] Patch Clearing flags on attachment: 103025 Committed r92466: <http://trac.webkit.org/changeset/92466> All reviewed patches have been landed. Closing bug. Reopen this bug since the following tests are still failing: BUGWK64942 WIN GPU : compositing/color-matching/image-color-matching.html = IMAGE BUGWK64942 WIN GPU : compositing/direct-image-compositing.html = IMAGE BUGWK64942 WIN GPU : compositing/geometry/ancestor-overflow-change.html = IMAGE BUGWK64942 WIN GPU : compositing/geometry/fixed-position.html = IMAGE BUGWK64942 WIN GPU : compositing/geometry/horizontal-scroll-composited.html = IMAGE BUGWK64942 WIN GPU : compositing/geometry/layer-due-to-layer-children-deep.html = IMAGE BUGWK64942 WIN GPU : compositing/geometry/layer-due-to-layer-children.html = IMAGE BUGWK64942 WIN GPU : compositing/geometry/vertical-scroll-composited.html = IMAGE BUGWK64942 WIN GPU : compositing/iframes/composited-iframe-alignment.html = IMAGE BUGWK64942 WIN GPU : compositing/masks/masked-ancestor.html = IMAGE BUGWK64942 WIN GPU : compositing/overflow/fixed-position-ancestor-clip.html = IMAGE BUGWK64942 WIN GPU : compositing/reflections/nested-reflection-transition.html = IMAGE BUGWK64942 WIN GPU : compositing/reflections/transform-inside-reflection.html = IMAGE BUGWK64942 WIN GPU : compositing/shadows/shadow-drawing.html = IMAGE BUGWK64942 WIN MAC GPU : compositing/transitions/scale-transition-no-start.html = IMAGE BUGWK64942 MAC GPU : media/video-transformed.html = IMAGE BUGWK64942 MAC GPU : media/video-zoom-controls.html = IMAGE BUGWK64942 MAC GPU : platform/chromium/compositing/backface-visibility-transformed.html = IMAGE BUGWK64942 MAC GPU : platform/chromium/compositing/huge-layer-rotated.html = IMAGE BUGWK64942 MAC GPU : platform/chromium/compositing/layout-width-change.html = IMAGE BUGWK64942 MAC GPU : platform/chromium/compositing/perpendicular-layer-sorting.html = IMAGE BUGWK64942 MAC GPU : platform/chromium/compositing/tiny-layer-rotated.html = IMAGE Created attachment 103244 [details]
Patch
Some of the expected images were not included in the previous patch. I suspect that it is related to the size of the patch. webkit-patch upload seem to be having issues with large patches. This new patch rebaselines the tests that were somehow left out in previous patch. Comment on attachment 103244 [details]
Patch
rebaselines look OK, but this patch doesn't apply to ToT. It looks like there's some garbage instead of LayoutTests/platform/chromium-gpu-win/compositing/transitions/scale-transition-no-start-expected.png. I don't think our bugzilla scripts really work for patches this big :/
Landed rebaselines http://trac.webkit.org/changeset/92793. Sadly rebaselining is something that our tooling doesn't really handle for non-committers. Oh well :( |