Bug 65735 – Add detail to ASSERT message in IDBTransaction::enqueueEvent

• Component: New Bugs
• Status: RESOLVED FIXED

[David Grogan]

Add detail to ASSERT message in IDBTransaction::enqueueEvent

[David Grogan]

Created attachment 103009 [details]
Patch

[David Grogan]

Comment on attachment 103009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103009&action=review

> Source/WebCore/storage/IDBTransaction.cpp:185
> +    ASSERT_WITH_MESSAGE(!m_finished, "!m_finished, about to enqueue an event of type %s", event->type().string().utf8().data());

Will this print out the !m_finished for me?

[Hans Wennborg]

(In reply to comment #2)
> (From update of attachment 103009 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=103009&action=review
> 
> > Source/WebCore/storage/IDBTransaction.cpp:185
> > +    ASSERT_WITH_MESSAGE(!m_finished, "!m_finished, about to enqueue an event of type %s", event->type().string().utf8().data());
> 
> Will this print out the !m_finished for me?

Not sure I understand what you mean.. I suppose it will print when the assertion doesn't hold, i.e. when m_finished == true?

[David Grogan]

Created attachment 103094 [details]
Patch

[David Grogan]

Comment on attachment 103009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103009&action=review

>>> Source/WebCore/storage/IDBTransaction.cpp:185
>>> +    ASSERT_WITH_MESSAGE(!m_finished, "!m_finished, about to enqueue an event of type %s", event->type().string().utf8().data());
>> 
>> Will this print out the !m_finished for me?
> 
> Not sure I understand what you mean.. I suppose it will print when the assertion doesn't hold, i.e. when m_finished == true?

if the assertion fails with ASSERT(!m_finished), it prints out "!m_finished\n file, line etc".  
if the assertion fails with ASSERT_WITH_MESSAGE(!m_finished, "some stuff") I didn't know if the assertion would print
"!m_finished, some stuff\n file line etc"
or just
"some stuff\n file line etc"

Turns out it's the first, '!m_finished' is included so I don't need to explicitly print it.

[David Grogan]

Created attachment 103096 [details]
Patch

[Hans Wennborg]

(In reply to comment #6)
> Created an attachment (id=103096) [details]
> Patch

LGTM

[David Grogan]

Nate, could you review this?

[WebKit Review Bot]

Comment on attachment 103096 [details]
Patch

Clearing flags on attachment: 103096

Committed r92627: <http://trac.webkit.org/changeset/92627>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.