Bug 65731

Summary: Add ParentClass typedef in all JSC classes
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, oliver, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Mark Hahnenberg 2011-08-04 16:05:32 PDT 
Eventually we'd like to get rid of the vtable pointer in all of the JSC classes and use explicit super class calls for all inherited methods.  To make that future task simpler (and more template-able), it would be a good idea to add a typedef to each class by which we can uniformly refer to its parent class in the inheritance hierarhcy.
Comment 1 Mark Hahnenberg 2011-08-05 13:41:34 PDT 
Created attachment 103100 [details]
Patch
Comment 2 Mark Hahnenberg 2011-08-05 14:33:00 PDT 
Created attachment 103115 [details]
Patch
Comment 3 Gavin Barraclough 2011-08-07 13:55:17 PDT 
Hi Mark,

Did you want this patch reviewing, or is this still work in progress? - the review flag isn't set & it's unclear from the description.

G.
Comment 4 Mark Hahnenberg 2011-08-08 08:21:22 PDT 
(In reply to comment #3)
> Hi Mark,
> 
> Did you want this patch reviewing, or is this still work in progress? - the review flag isn't set & it's unclear from the description.
> 
> G.

Still trying to get Windows to build.  Getting some mysterious template-related errors on just Windows :-(
Comment 5 Mark Hahnenberg 2011-08-08 16:41:44 PDT 
Created attachment 103312 [details]
Patch
Comment 6 Oliver Hunt 2011-08-09 12:44:58 PDT 
Comment on attachment 103312 [details]
Patch

r=me
Comment 7 WebKit Review Bot 2011-08-09 13:46:34 PDT 
Comment on attachment 103312 [details]
Patch

Clearing flags on attachment: 103312

Committed r92706: <http://trac.webkit.org/changeset/92706>
Comment 8 WebKit Review Bot 2011-08-09 13:46:39 PDT 
All reviewed patches have been landed.  Closing bug.