Bug 65720

Summary: Add code to determine whether a Range in inside fixed position content
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: joepeck, mitz, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mitz: review+, webkit.review.bot: commit-queue-
Patch sam: review+

Simon Fraser (smfr)
Reported 2011-08-04 14:29:02 PDT
I need to be able to determine whether a Range is partially, or entirely within fixed position content.
Attachments
Patch (26.12 KB, patch)
2011-08-04 14:31 PDT, Simon Fraser (smfr) 		mitz: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (28.33 KB, patch)
2011-08-04 17:33 PDT, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-08-04 14:29:41 PDT
Going to bring back some of the changes from r89754 for this.
Simon Fraser (smfr)
Comment 2 2011-08-04 14:31:37 PDT
Created attachment 102982 [details] Patch
WebKit Review Bot
Comment 3 2011-08-04 15:08:47 PDT
Comment on attachment 102982 [details] Patch Attachment 102982 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9304635
Simon Fraser (smfr)
Comment 4 2011-08-04 17:27:58 PDT
Comment on attachment 102982 [details] Patch Landed in http://trac.webkit.org/changeset/92434 with build fix in http://trac.webkit.org/changeset/92435
Simon Fraser (smfr)
Comment 5 2011-08-04 17:33:56 PDT
Created attachment 103010 [details] Patch
Sam Weinig
Comment 6 2011-08-04 17:46:33 PDT
Comment on attachment 103010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103010&action=review > Source/WebCore/rendering/RenderBlock.h:653 > + virtual void absoluteQuads(Vector<FloatQuad>&, bool*); This bool should have a parameter name. > Source/WebCore/rendering/RenderBox.h:231 > + virtual void absoluteQuads(Vector<FloatQuad>&, bool*); This bool should have a parameter name. > Source/WebCore/rendering/RenderInline.h:50 > + virtual void absoluteQuads(Vector<FloatQuad>&, bool*); This bool should have a parameter name. > Source/WebCore/rendering/svg/RenderSVGModelObject.h:59 > + virtual void absoluteQuads(Vector<FloatQuad>&, bool*); This bool should have a parameter name. > Source/WebCore/rendering/svg/RenderSVGText.h:63 > + virtual void absoluteQuads(Vector<FloatQuad>&, bool*); This bool should have a parameter name.
Simon Fraser (smfr)
Comment 7 2011-08-04 18:07:34 PDT
http://trac.webkit.org/changeset/92438
Ryosuke Niwa
Comment 8 2011-08-04 23:20:29 PDT
It appears that scrollbars/scrollbar-drag-thumb-with-large-content.html started failing on Qt after this patch (this test is skipped on Snow Leopard per bug 65434): http://build.webkit.org/builders/Qt%20Linux%20Release/builds/36170 http://build.webkit.org/builders/Qt%20Linux%20Release/builds/36171
Note You need to log in before you can comment on or make changes to this bug.