Summary: | New Web (DOM) Inspector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||
Component: | WebKit Misc. | Assignee: | Timothy Hatcher <timothy> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | ||||||||
Priority: | P3 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Timothy Hatcher
2006-01-15 16:53:19 PST
Created attachment 5707 [details]
Inspector Patch (first cut)
This patch gets the Inspector working and living in WebKit. Accessible from a
contextual menu when the WebKitEnableInspectElementContextMenuItem default is
true or you have a development build. Browsing the tree, serialized HTML and
CSS rules work.
Created attachment 5708 [details]
Images (First Cut)
Images that go with the first cut patch.
Comment on attachment 5707 [details]
Inspector Patch (first cut)
+ scrollIntoViewIfNeeded DOMElement::ScrollIntoView
DontDelete|Function 1
Bug on this line. Needs to say DOMElement::ScrollIntoViewIfNeeded.
+ return rects;
+ } else if(!firstChild())
+ return QValueList<IntRect>();
No need for else after return. Need space after if.
+ RenderObject *child = firstChild();
+ while (child) {
More elegant to write the above as a for loop.
+ return IntRect(0,0,0,0);
Should use spaces after commas.
-@interface DOMElement (DOMElementExtensions)
-- (void)focus;
-- (void)blur;
-@end
-
Not good to move public API out of a public header DOMExtensions.h. Should put
the new stuff in a new category temporarily and leave the already-public stuff
public.
Are we going to make this localizable?
+ return [_private->searchResults count];
+ else if (!item)
+ return 1;
No need for else after return.
+ return [_private->searchResults objectAtIndex:index];
+ else if (!item)
+ return _private->rootNode;
Again.
+ DOMNode *currentNode = [node parentNode];
+ while (currentNode) {
+ if ([self isSameNode:currentNode])
+ return YES;
+ currentNode = [currentNode parentNode];
+ }
Above looks like it should be a for loop.
Looks like a great start. At least that very first thing I mentioned should be
fixed before landing, but I'm going to be loose here and say review+. Lets get
that first cut in there!
r=me
|