| Summary: | REGRESSION (r91540): Favicons are not loaded | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Daniel Bramhall <dbramhall> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Rafael Brandao <rafael.lobo> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Critical | CC: | abarth, ap, darin, rafael.lobo, webkit.review.bot | ||||||||||
| Priority: | P1 | Keywords: | InRadar | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | OS X 10.7 | ||||||||||||
| URL: | All webpages | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 102928 [details]
Bookmarks Menu View
Created attachment 102929 [details]
Bookmarks Window
What I'm seeing is that favicons that Safari has already stored are shown successfully, but new ones won't load. Regression range: r91538 - r91541. http://trac.webkit.org/changeset/91540 is pretty tiny. It should be easy to diagnose what's going wrong. Finally figured out. On Webkit2, there's another implementation of IconDatabaseBase known as WebIconDatabaseProxy, but it doesn't reimplement documentCanHaveIcon, so by default it will reject all favicon loads. Working on a patch to fix this. Created attachment 103146 [details]
Move documentCanHaveIcon to WebCore's scope, so it won't need to be reimplemented.
As explained before, this is just moving the function documentCanHaveIcon to somewhere else, visible to both IconController and IconDatabase, now without the need to add the same code for every IconDatabaseBase reimplementation.
Comment on attachment 103146 [details] Move documentCanHaveIcon to WebCore's scope, so it won't need to be reimplemented. Clearing flags on attachment: 103146 Committed r92551: <http://trac.webkit.org/changeset/92551> All reviewed patches have been landed. Closing bug. Comment on attachment 103146 [details]
Move documentCanHaveIcon to WebCore's scope, so it won't need to be reimplemented.
No test? If we can't test icon loading, we're going to keep breaking it. :(
|
Created attachment 102927 [details] Address Bar Favicon No favicons render or appear in either the address bar or the bookmarks menu (or in any part of the application for that matter). This did happen in an early beta preview of Safari and since then has been corrected although seems to have appeared in WebKit...