Bug 65687

Summary:

Web Inspector: rename sendResultByValue to returnByValue in Runtime agent.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+

Pavel Feldman

Reported 2011-08-04 08:01:07 PDT

Patch to follow.

Attachments
Patch (13.29 KB, patch) 2011-08-04 08:56 PDT, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-08-04 08:56:29 PDT

Created attachment 102923 [details] Patch

WebKit Review Bot

Comment 2 2011-08-04 08:59:20 PDT

Attachment 102923 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/inspector/InjectedScript.cpp:57: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InjectedScript.cpp:67: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorRuntimeAgent.cpp:65: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Source/WebCore/inspector/InspectorRuntimeAgent.cpp:99: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 4 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Pavel Feldman

Comment 3 2011-08-04 09:09:16 PDT

Committed r92377: <http://trac.webkit.org/changeset/92377>

Note You need to log in before you can comment on or make changes to this bug.