Bug 65680

Summary: [EFL] ewk_view_mode_get uses macro for NULL checks.
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, gyuyoung.kim, leandro, lucas.de.marchi, rakuco, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
updated patch
none
updated patch
gyuyoung.kim: commit-queue-
updated patch to a new coding style of WebKit-EFL none

Grzegorz Czajkowski
Reported 2011-08-04 03:39:45 PDT
Function ewk_view_mode_get checks NULL through ewk_view' macros.
Attachments
proposed patch (1.28 KB, patch)
2011-08-04 03:40 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch (1.46 KB, patch)
2011-08-04 07:19 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch (1.52 KB, patch)
2011-10-20 23:43 PDT, Grzegorz Czajkowski 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
updated patch to a new coding style of WebKit-EFL (1.54 KB, patch)
2011-10-21 00:09 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-08-04 03:40:55 PDT
Created attachment 102895 [details] proposed patch
Leandro Pereira
Comment 2 2011-08-04 06:45:49 PDT
Code changes looks fine, but ChangeLog entry needs more work.
Grzegorz Czajkowski
Comment 3 2011-08-04 07:19:13 PDT
Created attachment 102913 [details] updated patch Description in ChangeLog has been changed.
Gyuyoung Kim
Comment 4 2011-08-08 00:41:32 PDT
Comment on attachment 102913 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=102913&action=review > Source/WebKit/efl/ChangeLog:10 > + - the code is smaller, It seems '-' is not unneeded. Kenneth pointed it before in other bug.
Gyuyoung Kim
Comment 5 2011-08-08 00:48:34 PDT
(In reply to comment #4) > It seems '-' is not unneeded. Oops. '-' is unneeded. wrong expression. :(
Leandro Pereira
Comment 6 2011-08-08 10:04:21 PDT
Comment on attachment 102913 [details] updated patch Informal r+.
Gyuyoung Kim
Comment 7 2011-08-23 20:48:24 PDT
Hello Kent, we hope to review this patch. :-)
Ryosuke Niwa
Comment 8 2011-10-20 23:14:08 PDT
Comment on attachment 102913 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=102913&action=review >> Source/WebKit/efl/ChangeLog:10 >> + - the code is smaller, > > It seems '-' is not unneeded. Kenneth pointed it before in other bug. Yes remove '-' and put them all in a plain sentence.
Grzegorz Czajkowski
Comment 9 2011-10-20 23:43:28 PDT
Created attachment 111910 [details] updated patch
Gyuyoung Kim
Comment 10 2011-10-20 23:47:24 PDT
Comment on attachment 111910 [details] updated patch Attachment 111910 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10180793
Gyuyoung Kim
Comment 11 2011-10-20 23:49:46 PDT
Comment on attachment 111910 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=111910&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:3791 > + EWK_VIEW_SD_GET_OR_RETURN(o, sd, mode); Why do you use *o* instead of ewkView ? And also, Bug 69988 is changing *sd* variable name with *smartData*.
Grzegorz Czajkowski
Comment 12 2011-10-21 00:09:27 PDT
Created attachment 111917 [details] updated patch to a new coding style of WebKit-EFL
Gyuyoung Kim
Comment 13 2011-10-21 00:15:50 PDT
Comment on attachment 111917 [details] updated patch to a new coding style of WebKit-EFL LGTM.
WebKit Review Bot
Comment 14 2011-10-21 01:31:08 PDT
Comment on attachment 111917 [details] updated patch to a new coding style of WebKit-EFL Clearing flags on attachment: 111917 Committed r98084: <http://trac.webkit.org/changeset/98084>
WebKit Review Bot
Comment 15 2011-10-21 01:31:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.