Bug 65675

Summary: Eval handling attempts literal parsing even when the eval string is in the cache
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Description Filip Pizlo 2011-08-04 02:35:01 PDT 
Interpreter::callEval should first check if the string is in the eval code cache, and only attempt literal parsing if it isn't.
Comment 1 Filip Pizlo 2011-08-04 02:38:56 PDT 
Created attachment 102890 [details]
the patch

Tests still running.
Comment 2 Filip Pizlo 2011-08-04 02:45:49 PDT 
Comment on attachment 102890 [details]
the patch

Tests pass, ready for review.
Comment 3 Oliver Hunt 2011-08-04 09:49:53 PDT 
Comment on attachment 102890 [details]
the patch

ouchies
Comment 4 WebKit Review Bot 2011-08-04 10:48:57 PDT 
Comment on attachment 102890 [details]
the patch

Clearing flags on attachment: 102890

Committed r92386: <http://trac.webkit.org/changeset/92386>
Comment 5 WebKit Review Bot 2011-08-04 10:49:01 PDT 
All reviewed patches have been landed.  Closing bug.