Bug 65675

Summary: Eval handling attempts literal parsing even when the eval string is in the cache
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch none

Filip Pizlo
Reported 2011-08-04 02:35:01 PDT
Interpreter::callEval should first check if the string is in the eval code cache, and only attempt literal parsing if it isn't.
Attachments
the patch (5.96 KB, patch)
2011-08-04 02:38 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-08-04 02:38:56 PDT
Created attachment 102890 [details] the patch Tests still running.
Filip Pizlo
Comment 2 2011-08-04 02:45:49 PDT
Comment on attachment 102890 [details] the patch Tests pass, ready for review.
Oliver Hunt
Comment 3 2011-08-04 09:49:53 PDT
Comment on attachment 102890 [details] the patch ouchies
WebKit Review Bot
Comment 4 2011-08-04 10:48:57 PDT
Comment on attachment 102890 [details] the patch Clearing flags on attachment: 102890 Committed r92386: <http://trac.webkit.org/changeset/92386>
WebKit Review Bot
Comment 5 2011-08-04 10:49:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.