Bug 65655

Summary: [chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: kbr, senorblanco, tomhudson, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

James Robinson
Reported 2011-08-03 16:32:52 PDT
[chromium] Implement a global resource limit for DrawingBuffer to limit the amount of GPU memory used by 2d canvas backing stores
Attachments
Patch (3.97 KB, patch)
2011-08-03 16:34 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (3.87 KB, patch)
2011-08-03 16:45 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-08-03 16:34:54 PDT
Created attachment 102856 [details] Patch
James Robinson
Comment 2 2011-08-03 16:45:03 PDT
Created attachment 102860 [details] Patch
James Robinson
Comment 3 2011-08-03 16:52:30 PDT
This patch is necessary for wilderness downtown, which tries to create 475mb worth of DrawingBuffer textures/stencil buffers without this patch. We can extend this in the future to allow setting the limit dynamically, and possibly do readbacks for DrawingBuffers if memory gets tight, but this seems like a good start and should work for now. I picked a limit (somewhat arbitrarily) of 16megapixels, which means 128mb of vram assuming 4 bytes/pixel for the color attachment and 4 bytes/pixel for the stencil buffer, assuming that it's packed in the card.
Kenneth Russell
Comment 4 2011-08-04 14:07:12 PDT
Comment on attachment 102860 [details] Patch This looks okay to me as a first pass workaround. Assuming it's been tested.
WebKit Review Bot
Comment 5 2011-08-04 16:47:12 PDT
Comment on attachment 102860 [details] Patch Clearing flags on attachment: 102860 Committed r92430: <http://trac.webkit.org/changeset/92430>
WebKit Review Bot
Comment 6 2011-08-04 16:47:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.