Bug 6561 – run-javascriptcore-tests doesn't work

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

$ run-javascriptcore-tests 
Invalid version number at Getopt/Mixed.pm line 52.
BEGIN failed--compilation aborted at Getopt/Mixed.pm line 55.
Compilation failed in require at jsDriver.pl line 40.
BEGIN failed--compilation aborted at jsDriver.pl line 40.

In Mixed.pm:
    # Convert RCS revision number (must be main branch) to d.ddd format:
    ' $Revision: 7020 $ ' =~ / (\d+)\.(\d{1,3}) /
        or die "Invalid version number";

The correct revision number to have here is 1.8 (CVS WebKit used to have 1.1, which was wrong).

This has apparently happened with svn migration; not sure about what steps to fix would be right 
(might require some svn magic).

[Mark Rowe (bdash)]

Created attachment 5695 [details]
Change exactly as Alexey describes.

No SVN magic is needed.  The file in question has already had keyword expansion
disabled.

[Alexey Proskuryakov]

Created attachment 5696 [details]
proposed fix

Ok, Mark (bdash) says there's no longer any magic in this file, and the
revision can be simply replaced with a correct value :)

[Anders Carlsson]

Comment on attachment 5696 [details]
proposed fix

Why should the revision number be 1.8?

r=me

[Alexey Proskuryakov]

1.008 is the version of WebKit's copy, see <http://search.cpan.org/src/CJM/Getopt-Mixed-1.008/lib/
Getopt/Mixed.pm>.